ci: scope composite-action path filters to their suite#310
Merged
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe CI workflow now uses narrower path filters so suites rerun only for their own code, composite action, and workflow file changes. The shared filter keeps Rust crates, root manifests, ChangesCI path filter changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Narrow the
changesjob's path filters so a composite-action edit only reruns the suites that actually use it.Why
sharedmatched.github/actions/**, and every suite includes*shared— so editing any composite action (e.g.setup-java) reran rust + python + node + java. Thesetup-java@v5bump in #309 fired the whole Python/Node matrix for nothing.Research consensus: over-triggering wastes minutes, under-triggering ships untested bugs. Narrowing is safe only for single-consumer actions; the map was grep-verified:
setup-rustsharedsetup-pythonrust-preludesetup-nodesetup-javaChange
sharedkeeps onlysetup-rust; each suite lists the actions it consumes. No suite loses a dependency it had (no under-trigger), single-consumer actions stop fanning out to all four (no over-trigger).Summary by CodeRabbit